[vlc-devel] [PATCH] This commit introduces two new ways to enable/disable effects via libvlc API: * libvlc_video_set_filters_string: permits to specify the enabled effects as a one-line string * libvlc_video_set_filter: permits to specify only one effect to enable or disable and the functions does the rest to keep it coherent
Rémi Denis-Courmont
remi at remlab.net
Sun Feb 16 15:40:33 CET 2020
Hi,
Le sunnuntaina 16. helmikuuta 2020, 15.44.50 EET Roman Minyaylov
roman.minyaylov at gmail.com a écrit :
> From: Roman Minyaylov <roman.minyaylov at gmail.com>
The summary should be here, not in the title where nobody can read it.
> ---
> include/vlc/libvlc_media_player.h | 20 ++++
> lib/libvlc.sym | 2 +
> lib/video.c | 158 ++++++++++++++++++++++++++++++
> 3 files changed, 180 insertions(+)
>
> diff --git a/include/vlc/libvlc_media_player.h
> b/include/vlc/libvlc_media_player.h index aa4be73418..abb4801a83 100644
> --- a/include/vlc/libvlc_media_player.h
> +++ b/include/vlc/libvlc_media_player.h
> @@ -1913,6 +1913,26 @@ LIBVLC_API float libvlc_video_get_adjust_float(
> libvlc_media_player_t *p_mi, LIBVLC_API void libvlc_video_set_adjust_float(
> libvlc_media_player_t *p_mi, unsigned option, float value );
>
> +/** Set the video filters string
> + *
> + * \param p_mi the media player
> + * \param psz_filter_type the filters type
> + * \param psz_string the filters string
> + */
I don't understand the documentation here, and if I don't, it's very unlikely
that third party developers will either.
> +LIBVLC_API void libvlc_video_set_filters_string( libvlc_media_player_t
> *p_mi, + const char *psz_filter_type, +
> const char *psz_string );
> +
> +/**
> + * Set (enable/disable) a video filter
> + *
> + * \param p_mi the media player
> + * \param psz_name the filter name
> + * \param b_add boolean for whether the filter is to enable or disable
> + */
> +LIBVLC_API void libvlc_video_set_filter( libvlc_media_player_t *p_mi, const
> char *psz_name, + bool b_enable );
How does the application developer know the filter name?
If the input has multiple tracks, how does it select which track the filter is
applied to?
--
Rémi Denis-Courmont
http://www.remlab.net/
More information about the vlc-devel
mailing list