[vlc-devel] [PATCH] doc: add a Makefile to build sample apps

[Rémi Denis-Courmont]

Hi,

Ideally everything would be compiled in distcheck. But you've got to be realistic here - distcheck cannot depend on Qt, and even less on DirectX, to pass.

Le 17 février 2020 12:26:14 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Fri, Feb 14, 2020, at 14:53, Rémi Denis-Courmont wrote:
>> Hi,
>> 
>> Ok with me *if* it passes distcheck.
>
>Should these samples be compiled when doing a distcheck ? I guess so.
>
>> 
>> Le 14 février 2020 15:42:29 GMT+02:00, Steve Lhomme
><robux4 at ycbcr.xyz> a écrit :
>>>  configure.ac           |  1 +
>>>  doc/libvlc/Makefile.am | 34 ++++++++++++++++++++++++++++++++++
>>>  2 files changed, 35 insertions(+)
>>>  create mode 100644 doc/libvlc/Makefile.am
>>> 
>>> diff --git a/configure.ac b/configure.ac
>>> index 7741ddca554..45f88565b1f 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -4529,6 +4529,7 @@ AC_SUBST([FILE_LIBVLC_DLL])
>>>  AC_CONFIG_FILES([
>>>    Makefile
>>>    doc/Makefile
>>> +  doc/libvlc/Makefile
>>>    modules/Makefile
>>>    m4/Makefile
>>>    po/Makefile.in
>>> diff --git a/doc/libvlc/Makefile.am b/doc/libvlc/Makefile.am
>>> new file mode 100644
>>> index 00000000000..d5c90042afa
>>> --- /dev/null
>>> +++ b/doc/libvlc/Makefile.am
>>> @@ -0,0 +1,34 @@
>>> +SUFFIXES = .c .cpp .ui .h .hpp .moc.cpp
>>> +
>>> +moc_verbose = $(moc_verbose_$(V))
>>> +moc_verbose_ = $(moc_verbose__$(AM_DEFAULT_VERBOSITY))
>>> +moc_verbose_0 = @echo "  MOC   " $@;
>>> +moc_verbose__0 = $(moc_verbose_0)
>>> +
>>> +nodist_qtgl_libvlc_SOURCES = qtvlcwidget.moc.cpp
>>> +
>>> +qtgl_libvlc_CXXFLAGS = $(AM_CXXFLAGS) $(QT_CFLAGS) $(CXXFLAGS_qt)
>>> +qtgl_libvlc_LDADD = $(QT_LIBS) $(LIBS_qt) $(LIBM)
>../../lib/libvlc.la
>>> +qtgl_libvlc_SOURCES = QtGL/main.cpp QtGL/qtvlcwidget.cpp
>QtGL/qtvlcwidget.h
>>> +
>>> +MOC_CPPFLAGS = $(DEFS) -I$(top_srcdir)/include
>-I$(top_builddir)/include -I$(top_builddir) \
>>> +	$(qtgl_libvlc_CPPFLAGS)
>>> +
>>> +d3d9_player_SOURCES = d3d9_player.c
>>> +d3d9_player_LDADD =  -ld3d9 ../../lib/libvlc.la
>>> +d3d9_player_LDFLAGS = $(AM_LDFLAGS) -mwindows -Wc,-static
>>> +
>>> +d3d11_player_SOURCES = d3d11_player.cpp
>>> +d3d11_player_LDADD =  -ld3d11 -ld3dcompiler_47 -luuid
>../../lib/libvlc.la
>>> +d3d11_player_LDFLAGS = $(AM_LDFLAGS) -mwindows -Wc,-static
>>> +
>>> +qtvlcwidget.moc.cpp: QtGL/qtvlcwidget.h
>>> +	$(moc_verbose)$(MOC) $(MOC_CPPFLAGS) -o $@ $<
>>> +
>>> +bin_PROGRAMS =
>>> +if HAVE_WIN32
>>> +bin_PROGRAMS += d3d11_player d3d9_player
>>> +endif
>>> +if ENABLE_QT
>>> +bin_PROGRAMS += qtgl_libvlc
>>> +endif
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200217/b1fc6041/attachment.html>