[vlc-devel] [PATCH] android: remove useless semaphore

Rémi Denis-Courmont remi at remlab.net
Wed Feb 19 18:31:38 CET 2020


> @@ -183,25 +182,13 @@ static void *detached_thread(void *data)
>      return NULL;
>  }
> 
> -static void finish_joinable_thread(void *data)
> -{
> -    vlc_thread_t th = data;
> -
> -    vlc_sem_post(&th->finished);
> -}
> -
>  static void *joinable_thread(void *data)
>  {
>      vlc_thread_t th = data;
>      void *ret;

This variable should also be removed.

> 
> -    vlc_cleanup_push(finish_joinable_thread, th);
>      thread = th;
> -    ret = th->entry(th->data);
> -    vlc_cleanup_pop();
> -    vlc_sem_post(&th->finished);
> -
> -    return ret;
> +    return th->entry(th->data);
>  }
> 
>  static int vlc_clone_attr (vlc_thread_t *th, void *(*entry) (void *),
-- 
Rémi Denis-Courmont
http://www.remlab.net/





More information about the vlc-devel mailing list