[vlc-devel] [PATCH] fix sigpipe crash and recover when bad network
janboe.ye at outlook.com
Fri Feb 21 19:34:37 CET 2020
Thanks for review!
> 2020年2月22日 上午1:21，Rémi Denis-Courmont <remi at remlab.net> 写道：
> Le perjantaina 21. helmikuuta 2020, 14.27.56 EET Janboe Ye a écrit :
>> From a9380d8033a3718f3cdb740c3a982d42037aa129 Mon Sep 17 00:00:00 2001
>> From: Janboe Ye <janboe.ye at gmail.com>
>> Date: Fri, 21 Feb 2020 15:25:22 +0800
>> Subject: [PATCH] fix sigpipe crash and recover when bad network
>> dsm will send sigpipe when bad network conditional and crash app.
>> This will disable sigpipe and recovery after writing failure
> That part looks OK now, but it should be submitted upstream too.
> (Sockets are still obviously not created correctly in thread-safe fashion, but
> that's a different and preexisting bug.)
Yes, I already created a pull request for libdsm.
>> prefetch thread will try to recovery by creating fake EOS.
> And that part still looks plain wrong. I don't know or care what you're trying
> to do here but it does not belong in the prefetch stream filter where it will
> break other input types.
Yes, I agree. It’d better to hand it in dsm access module and I will try to recover it in access module.
> Реми Дёни-Курмон
More information about the vlc-devel