[vlc-devel] [PATCH 1/2] aout: use vlc_atomic_rc_t

Rémi Denis-Courmont remi at remlab.net
Fri Feb 21 20:05:47 CET 2020

Le perjantaina 21. helmikuuta 2020, 19.32.24 EET Quentin Chateau a écrit :
> I fail to see what you mean, can you please give me some more info so I
> can meet your expectations:
>  1. Are you afraid of the counter overflowing the underlying unsigned int ?


>  2. How is it worse than before ?

This has already been discussed before. You can overflow uint on a 64-bits 
platform. There's already been exploits on other programs doing exactly that. 
You can't overflow uintptr_t since you can't have that many references in a 
single address space (and it would take forever).

>  3. What's the point of having helper functions for reference counting
>     if we should not use them ?

Don't ask me. They're pointless as far as I can see.


More information about the vlc-devel mailing list