[vlc-devel] [PATCH 1/2] aout/coreaudio: use vlc_mutex_t instead of pthread_mutex_t

[Thomas Guillem]

On Sat, Feb 22, 2020, at 03:23, Marvin Scholz wrote:
> The fact that currently vlc_mutex_t is the same as pthread_mutex_t
> is an implementation detail, there is no reason not to use vlc_mutex_t
> here.
> ---
>  modules/audio_output/coreaudio_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/modules/audio_output/coreaudio_common.h 
> b/modules/audio_output/coreaudio_common.h
> index 49f6779234..4bd6139493 100644
> --- a/modules/audio_output/coreaudio_common.h
> +++ b/modules/audio_output/coreaudio_common.h
> @@ -72,7 +72,7 @@ struct aout_sys_common
>  #pragma clang diagnostic ignored "-Wpartial-availability"
>          os_unfair_lock  unfair;
>  #pragma clang diagnostic pop
> -        pthread_mutex_t mutex;
> +        vlc_mutex_t     mutex;

LGTM.

Specially since the VLC API is used on this pthread_t mutex.

>      } lock;
>  
>      int                 i_rate;
> -- 
> 2.21.1 (Apple Git-122.3)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel