[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

[Marvin Scholz]

On 25 Feb 2020, at 6:56, Rémi Denis-Courmont wrote:

> Le maanantaina 24. helmikuuta 2020, 17.45.07 EET Marvin Scholz a 
> écrit :
>> even though it never modifies it.
>> Clang versions 7 or older did implement this quite strictly and
>> therefore errors when compiling this code:
>
> That's either a bug in that compiler version or possibly a minor 
> update not
> installed, or mistaken compiler flag (in other words, configure script 
> bug).
> Clang 7 officially supports C17/C18.

I tested all major versions before 7 and all are affected.
I can’t easily test minor versions between 7 or 8 as they are not 
available
on godbolt. Looking at the git repository though it seems the first 
fixed
version was 8.0.0.

Not sure what you mean by mistaken compiler flag here?

>
> And to call it C17 is a bit of a stretch. It's really just an 
> re-edition of
> C11 with editorial corrections gathered. The atomic spelling error was 
> already
> found and corrected in 2014.
>

It’s called C17 on open-std.org, thats why I used that here, not sure 
what else to
call it.

> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel