[vlc-devel] Revert HAVE_GL for vgl.c

Alexandre Janniaux ajanni at videolabs.io
Tue Feb 25 11:56:52 CET 2020


Hi,

Now that vgl.c doesn't depend on OpenGL headers anymore,
the patch 9d9c70a52d6727f10ca82ecf74646f9a07f210f2 should
probably be reverted as it prevents using vglmem on targets
that only have Opengl ES and no OpenGL headers, like android.

```
commit 9d9c70a52d6727f10ca82ecf74646f9a07f210f2
Refs: 4.0.0-dev-10949-g9d9c70a52d
Author:     Martin Storsjö <martin at martin.st>
AuthorDate: Tue Feb 11 11:59:11 2020 +0200
Commit:     Martin Storsjö <martin at martin.st>
CommitDate: Tue Feb 11 11:59:57 2020 +0200

    Disable the libvgl plugin if OpenGL isn't available

    This fixes building for Windows/ARM(64), which lacks OpenGL.

    Previously, this plugin has compiled just fine without OpenGL available,
    but since b6a47686dfe2f789780f902b776e864e5c386ac5, OpenGL headers
    were included here. Just skip the plugin in those cases.
```

Martin, would you have any opinion on this?

Regards,
--
Alexandre Janniaux
Videolabs


More information about the vlc-devel mailing list