[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

Rémi Denis-Courmont remi at remlab.net
Thu Feb 27 15:50:45 CET 2020


Point being, it's a compiler bug, which is already fixed. Don't use old buggy EOL compilers. This patch is wrong.

Le 27 février 2020 16:36:19 GMT+02:00, Alexandre Janniaux <ajanni at videolabs.io> a écrit :
>Hi,
>
>Yes, but according to the page ePirat linked, the DR 459 is
>fixed in C17 which is ISO/IEC 9899:2018, and previous
>revision was 9899:2012 if I'm not wrong.
>http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2244.htm
>https://www.iso.org/standard/61717.html
>
>About Clang 6 or 7 failing with std=c17, I don't know and
>might be the bug you mention (as it is fixed right after)
>but it doesn't impact us as we're not using C17/18 afaik.
>
>Regards,
>--
>Alexandre Janniaux
>Videolabs
>
>On Thu, Feb 27, 2020 at 03:59:41PM +0200, Rémi Denis-Courmont wrote:
>> Hi,
>>
>> C99 had 4 editions, the last one in 2007. C11 had at least 2 editions
>before 2017.
>>
>> But even if you consider the 2017 edition a different version
>altogether, how do you explain that clang 6 and 7 fail to build with
>-std=c17 ?
>>
>> Le 27 février 2020 14:50:49 GMT+02:00, Alexandre Janniaux
><ajanni at videolabs.io> a écrit :
>> >Hi,
>> >
>> >On Thu, Feb 27, 2020 at 01:14:52PM +0200, Rémi Denis-Courmont wrote:
>> >> If you think we should go back to pre-2011, you need to make a
>patch
>> >to fiw the C code and configure script accordingly. And this
>(C/C++11)
>> >*was* discussed and agreed upon here, by the way.
>> >
>> >This «mistake» is part of the last draft on C11 and, like
>> >ePirat mentionned it, the issue was raised on March 22 2014
>> >so it seems to be part of C11 standard afaik.
>> >
>> >Did something changed in the final private C11 norm with
>> >regards to this prototype? It would seem weird that the
>> >issue was raised three years later if it was already fixed.
>> >
>> >Regards,
>> >--
>> >Alexandre Janniaux
>> >Videolabs
>> >_______________________________________________
>> >vlc-devel mailing list
>> >To unsubscribe or modify your subscription options:
>> >https://mailman.videolan.org/listinfo/vlc-devel
>>
>> --
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté.
>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200227/b52262c8/attachment.html>


More information about the vlc-devel mailing list