[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

Romain Vimont rom1v at videolabs.io
Thu Feb 27 16:06:56 CET 2020

On 2/27/20 3:57 PM, Thomas Guillem wrote:
> On Thu, Feb 27, 2020, at 15:50, Rémi Denis-Courmont wrote:
>> Point being, it's a compiler bug, which is already fixed. Don't use 
>> old buggy EOL compilers. This patch is wrong.
> But we are still stating that VLC 4.0 can be built with "buggy EOL 
> compilers" like you said.
> So, the issue can't be closed until we either:
>   - Bump the compiler version from NEWS
>   - Apply this patch (or do any other fixes).

This patch just adds an harmless cast.

Whatever the decisions about which compiler we support or not support, 
if this tiny change allows to support more compilers, I'd prefer it to 
be merged.

Just my 2 cts.

More information about the vlc-devel mailing list