[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

[Thomas Guillem]

On Thu, Feb 27, 2020, at 19:20, Rémi Denis-Courmont wrote:
> Le torstaina 27. helmikuuta 2020, 16.20 EET Thomas Guillem a écrit :
> > On Thu, Feb 27, 2020, at 15:50, Rémi Denis-Courmont wrote:
> > > Point being, it's a compiler bug, which is already fixed. Don't use old
> > > buggy EOL compilers. This patch is wrong.
> > But we are still stating that VLC 4.0 can be built with "buggy EOL
> > compilers" like you said.
> > 
> > So, the issue can't be closed until we either:
> >  - Bump the compiler version from NEWS
> 
> That does not belong in the NEWS file at all. 99.999% of people browsing the 
> NEWS file don't care about the compiler used, even less about the minimum 
> compiler requirements.
> 
> This normally belongs in the INSTALL file, but even then, most people who do 
> build won't read that. They'll run the configure script, and possibly read wiki 
> pages. This needs to be checked by configure, as Marvin said.

I completely agree.

We could also need a CI running the oldest compiler when we switch to gitlab. 


> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel