[vlc-devel] [PATCHv2 09/10] es_out: accept all controls from timeshift

Thomas Guillem thomas at gllm.fr
Fri Feb 28 08:04:56 CET 2020

On Thu, Feb 27, 2020, at 21:46, Remi Denis-Courmont wrote:
> Le 2020-02-27 17:19, Thomas Guillem a écrit :
> > Directly forward them instead of asserting.
> If those controls have only one implementation, I presume that they 
> should be functions rather than controls. (This might also be a starting 
> point to later separate common code, like was done for the decoder.)

Yes, I thought about it but this is one major drawback: using the same struct definition for 2 different API.
There won't be any safeguard against using a es_out display function on any other es_outs.

There are 2 ways to fix it:
 - Add a enum type in es_out_t struct, and assert the type from es_out display functions.
 - Add an other type for es_out_t display, since only timeshift and input.c are the client, it won't need any modification in demux modules.

I can do that later, like I said, I would like to push my 43 patches branch first.
In the meantime, we can drop these  2 commits.

> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list