[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

[Thomas Guillem]

On Fri, Feb 28, 2020, at 07:34, Rémi Denis-Courmont wrote:
> This patch enables people to use outdated compilers that will miss modern optimisations and threat mitigation features from newer LLVM versions, which are available for all platforms that any VLC dev cares about. All of that to avoid one apt-get install or equivalent.
> 
> 15 years ago, when GCC was king and slow moving, supporting old compilers didn't make much difference. Now it does.
> 
> I completely disagree.

That is a valid point, I propose that we continue this discussion tomorrow.

> 
> Le 27 février 2020 17:06:56 GMT+02:00, Romain Vimont <rom1v at videolabs.io> a écrit :
>> 
>> 
>> On 2/27/20 3:57 PM, Thomas Guillem wrote:
>>> On Thu, Feb 27, 2020, at 15:50, Rémi Denis-Courmont wrote:
>>>> Point being, it's a compiler bug, which is already fixed. Don't use 
>>>> old buggy EOL compilers. This patch is wrong.
>>> But we are still stating that VLC 4.0 can be built with "buggy EOL 
>>> compilers" like you said.
>>> 
>>> So, the issue can't be closed until we either:
>>>   - Bump the compiler version from NEWS
>>>   - Apply this patch (or do any other fixes).
>> 
>> This patch just adds an harmless cast.
>> 
>> Whatever the decisions about which compiler we support or not support, 
>> if this tiny change allows to support more compilers, I'd prefer it to 
>> be merged.
>> 
>> Just my 2 cts.vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200228/c3e8f0ee/attachment.html>