[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

Rémi Denis-Courmont remi at remlab.net
Fri Feb 28 11:46:14 CET 2020


My experience shows the opposite. Installing or even compiling LLVM as a cross-compiler is easy and does not need root.

I suggest you read the forum. People don't know how to, can't or are afraid of, updating native system tools. I don't personally mind the Meson version. We could also list flex, bison, Luac, wayland-scanner, etc.

But unlike upgrading the host compiler, installing a cross-compiler is *not* hard, and it would be trivial to add it to tools if somebody cared.

And nothing requires using yooms from the NDK. Otherwise I don't think you could have compiled VLC on Android ever.

Le 28 février 2020 12:38:40 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Fri, Feb 28, 2020, at 11:15, Rémi Denis-Courmont wrote:
>> The agreement was to require C11 entirely except for Annex K and
>threads, but with atomic.
>> 
>> Later I dropped the requirement for timespec and timespec_get, with
>no objections that I'd recall. Steve dropped the requirement for
>aligned_alloc() *without* agreement.
>> 
>> Somebody apparently dropped support for GCC 5. I don't recall how
>that came up.
>> 
>> Now if you want to drop support for TC and DR's, that's on you.
>> 
>> And I still assert that it's inconsistent considering how recent
>versions of other tool we require, useless considering that fixed
>compilers are readily available, and even harmful as it implies worse
>diagnostics, optimisations and security mitigation features (e.g.
>branch protection).
>
>I disagree. It is way easier to pip install meson than updating a
>toolchain created for a given embedded device.
>
>> 
>> All of that because some want to use the built-in compiler of some
>old Android NDK versions.
>
>Naup, VLC for android requires the latest NDK version, that is a LTS
>(NDK 21, the one with clang 9 or 8).
>
>> 
>> Le 28 février 2020 11:34:03 GMT+02:00, "Hugo Beauzée-Luyssen"
><hugo at beauzee.fr> a écrit :
>>> On Fri, Feb 28, 2020, at 10:10 AM, Rémi Denis-Courmont wrote:
>>>> A strict C11 implementation follows errata. See, e.g. Clang 8, 9 or
>GCC 
>>>> which happily compile this code in C11 mode. This patch is wrong.
>>> 
>>> DR459 was fixed in C17. 
>>> Whatever the compiler does with this DR for any other C standard
>version is their business.
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200228/197638f4/attachment-0001.html>


More information about the vlc-devel mailing list