[vlc-devel] [PATCH 2/2] thread: fix compilation with clang 7 or older

[Denis Charmet]

Hi,

On 2020-02-27 15:50, Rémi Denis-Courmont wrote:
> Point being, it's a compiler bug, which is already fixed. Don't use
> old buggy EOL compilers. This patch is wrong.

I totally get your point and would normally agree with you but not 
everybody can update their toolchain, especially in embedded when you 
depend on whatever the SOC vendor delivers you. And let's not talk about 
the rest of the corporate world where we have to deal with people still 
using Ubuntu 16.04.

Dropping support for a compiler which is not particularily old (end of 
2018) just put more hassle on packagers than needed. We asked Steve not 
to commit his extra error flags for the exact same reason.

Sure the patch is useless in a perfect world but it's also, afaict, 
harmless. It's not the first time we've worked around compiler's issues 
in the code. We did it for MKV a few years ago when people complained. 
Please let's not fight over something like that.

Regards,
-- 
Denis Charmet - TypX
Le mauvais esprit est un art de vivre