[vlc-devel] [PATCH 5/5] vout_subpictures: force ephemer flag on stop time less spu

Steve Lhomme robux4 at ycbcr.xyz
Mon Jan 6 08:17:40 CET 2020


On 2020-01-03 15:15, Francois Cartegnie wrote:
> ---
>   src/video_output/vout_subpictures.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/src/video_output/vout_subpictures.c b/src/video_output/vout_subpictures.c
> index 71dc5e6648..3efd76ff1d 100644
> --- a/src/video_output/vout_subpictures.c
> +++ b/src/video_output/vout_subpictures.c
> @@ -701,6 +701,11 @@ spu_SelectSubpictures(spu_t *spu, vlc_tick_t system_now,
>                       selected_max_order = current->i_order;
>               }
>   
> +            /* An ephemer with stop time can be ephemer,
> +               but a pic without stop time must be ephemer */
> +            if(current->i_stop < current->i_start)

In an ideal world we could just check the i_stop is VLC_TICK_INVALID and 
assert if i_stop < i_start.

No objection on the patchset apart from the commit log.

> +                current->b_ephemer = true;
> +
>               /* If the spu is ephemer, the stop time is invalid, but it has been converted to
>                  system time and used in comparisons below */
>               const bool is_stop_valid = !current->b_ephemer || render_entry->orgstop > render_entry->orgstart;
> -- 
> 2.21.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list