[vlc-devel] [vlc-commits] codec: spudec: refactor spu fixes/validation

[Steve Lhomme]

On 2020-01-06 14:03, Francois Cartegnie wrote:
> Le 06/01/2020 à 08:08, Steve Lhomme a écrit :
> 
>>>    +    if( p_spu->i_stop <= p_spu->i_start && !p_spu->b_ephemer )
>>> +    {
>>> +        /* This subtitle will live for 5 seconds or until the next
>>> subtitle */
>>> +        p_spu->i_stop = p_spu->i_start + VLC_TICK_FROM_MS(500 * 11);
>>
>> What is the 11 for ? If you want 5s you should use VLC_TICK_FROM_SEC(5).
>>
> 
> I just refactor, that's not my code

Indeed, but that still seems odd.