[vlc-devel] [PATCH] access: add gopher input submodule to tcp.c

[Thomas Guillem]

On Wed, Jan 8, 2020, at 18:25, Vincenzo Nicosia wrote:
> On Wed, Jan 08, 2020 at 05:00:39PM +0100, Thomas Guillem wrote:
> > 
> > 
> > On Wed, Jan 8, 2020, at 14:48, Rémi Denis-Courmont wrote:
> > > This has nothing to do with the raw TCP protocol. By that logic why don't you merge tcp.c with file.c which is essentially doing the same thing except on Open...?
> > > 
> > > This makes no architectural sense. A separate protocol is a separate modulew especially if it's niche, so it can be left out.
> > 
> > I don't have strong opinions about that but I still tend to prefer having both module into one.
> > 
> > I can revert and merge the initial patch tomorrow, if you all agree with Rémi.
> > 
> 
> Either option is fine by me.
> 
> If you agree about going for a separate gopher module, I will re-send
> the patch to be applied for review, since we have had at least three
> different ones in this thread and there is a risk to apply the wrong
> one.
> 
> Waiting for the final verdict :)

OK, let separate the two modules then. Sorry for misleading you.

> 
> Thanks
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 
> *Attachments:*
>  * signature.asc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200109/5f94d59f/attachment.html>