[vlc-devel] [PATCH] player: vout: Update IsFullscreen and IsWallpaperModeEnabled for fixing toggle hotkey

[Alexandre Janniaux]

Hi,

I think there are missing vout_Release after the usage of
vlc_player_vout_Hold.

Regards,
--
Alexandre Janniaux
Videolabs

On Fri, Jan 10, 2020 at 09:10:01PM +0530, vvaakshay at gmail.com wrote:
> From: akshayaky <akymaster007 at gmail.com>
>
> now the player returns state of the first vout instead of player state
>
> this commit fixes:
>    -the fullscreen hotkey not exiting fullscreen
>    -wallpaper mode hotkey not disabling wallpaper mode
>
> this commit fixes issue #22418
> ---
>  src/player/vout.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/player/vout.c b/src/player/vout.c
> index b28599288f..a8af445026 100644
> --- a/src/player/vout.c
> +++ b/src/player/vout.c
> @@ -100,7 +100,8 @@ vlc_player_vout_RemoveListener(vlc_player_t *player,
>  bool
>  vlc_player_vout_IsFullscreen(vlc_player_t *player)
>  {
> -    return var_GetBool(player, "fullscreen");
> +    vout_thread_t *vout = vlc_player_vout_Hold(player);
> +    return var_GetBool(vout, "fullscreen");
>  }
>
>  static int
> @@ -185,7 +186,8 @@ vlc_player_vout_SetFullscreen(vlc_player_t *player, bool enabled)
>  bool
>  vlc_player_vout_IsWallpaperModeEnabled(vlc_player_t *player)
>  {
> -    return var_GetBool(player, "video-wallpaper");
> +    vout_thread_t *vout = vlc_player_vout_Hold(player);
> +    return var_GetBool(vout, "fullscreen");
>  }
>
>  void
> --
> 2.17.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel