[vlc-devel] [PATCH] player: Remove unused vout variables

[Thomas Guillem]

On Mon, Jan 13, 2020, at 08:50, Steve Lhomme wrote:
> Hi,
> 
> This commit is a bit dry on explanations.
> 
> Looking at "video-wallpaper" it seems to be set/get from the player with 
> a public API. If you remove the variable you have to remove the matching 
> code as well.

After "player: vout: Update IsFullscreen and IsWallpaperModeEnabled for fixing toggle hotkey" is applied (from the same author).
"video-wallpaper" won't be set/get from the player.

The explanation could be: "these variables are not used anymore by the playe, but by the vout directly"

> 
> On 2020-01-10 16:55, vvaakshay at gmail.com wrote:
> > From: akshayaky <akymaster007 at gmail.com>
> > 
> > ---
> >   src/player/player.c | 5 -----
> >   1 file changed, 5 deletions(-)
> > 
> > diff --git a/src/player/player.c b/src/player/player.c
> > index 6835ad3409..85cca86e0b 100644
> > --- a/src/player/player.c
> > +++ b/src/player/player.c
> > @@ -1930,11 +1930,6 @@ vlc_player_New(vlc_object_t *parent, enum vlc_player_lock_type lock_type,
> >       VAR_CREATE("sub-text-scale", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT);
> >       VAR_CREATE("demux-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT);
> >   
> > -    /* vout variables */
> > -    VAR_CREATE("fullscreen", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
> > -    VAR_CREATE("video-on-top", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
> > -    VAR_CREATE("video-wallpaper", VLC_VAR_BOOL | VLC_VAR_DOINHERIT);
> > -
> >       /* aout variables */
> >       VAR_CREATE("audio-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT);
> >       VAR_CREATE("mute", VLC_VAR_BOOL);
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel