[vlc-devel] [PATCH] Dynamic rtp configurable payload type

[Rémi Denis-Courmont]

Le maanantaina 13. tammikuuta 2020, 15.52.07 EET Alessandro bietresato a écrit 
:
> Il 13/01/2020 12:08, Rémi Denis-Courmont ha scritto:
> > This looks like completely pointless code complexity. No thanks.
> 
> Hi,
> 
> In my company we needed to set payload type to 120 to stream to a custom
> hardware device, without SDP excange.
> I made this patch since I did not found any other mean to force it (it
> seems hard-coded to 96, for dynamic types).

This does not fix any VLC bug and yet brings a number of problems:
- can break RTCP mux.
- assumes a single PT per ES, preventing any future support for journaling 
(e.g. MIDI), FEC, etc.
- assumes that a fixed set of parameters for any given input ES format (since 
the SDP is not being parsed),
- prevents defining any new static formats in the future if necessary.

If a spec has assigned PT 120 for something, then refer to the spec and 
implement that correctly. This should not be a CLI variable IMO.

-- 
レミ・デニ-クールモン
http://www.remlab.net/