[vlc-devel] [PATCH] mmal: update the code from the one actually used in Raspbian

[Rémi Denis-Courmont]

Le keskiviikkona 15. tammikuuta 2020, 17.46.31 EET Steve Lhomme a écrit :
> From: John Cox <jc at kynesim.co.uk>
> 
> Tested with basic video playback on a RPI 3B+
> 
> This is the code from the Raspbian patch ported to the 4.0 architecture.
> It includes an OpenGL interop module and some NEON optimizations.

I don't think it's appropriate to make a big code dump. That's too hard to 
review properly.

And it's questionable why to merge the code at all. If the author could not be 
bothered to submit it themselves, then there's no reason to believe that it 
won't immediately bit-rot, and the same problems won't occur again and again.

> diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
> index 9b4ea14c31b..ef83ac3b4ad 100644
> --- a/src/misc/fourcc.c
> +++ b/src/misc/fourcc.c
> @@ -816,8 +816,13 @@ static const struct
>      { { VLC_CODEC_VDPAU_VIDEO_420, VLC_CODEC_VDPAU_VIDEO_422,
>          VLC_CODEC_VDPAU_VIDEO_444, VLC_CODEC_VDPAU_OUTPUT },
>                                                 FAKE_FMT() },
> -    { { VLC_CODEC_ANDROID_OPAQUE, VLC_CODEC_MMAL_OPAQUE,
> -        VLC_CODEC_D3D9_OPAQUE,    VLC_CODEC_D3D11_OPAQUE },
> +    { { VLC_CODEC_ANDROID_OPAQUE },            FAKE_FMT() },
> +    { { VLC_CODEC_MMAL_OPAQUE, VLC_CODEC_MMAL_ZC_SAND30   },
> +                                               FAKE_FMT() },
> +    { { VLC_CODEC_MMAL_ZC_I420,   VLC_CODEC_MMAL_ZC_SAND8,
> +        VLC_CODEC_MMAL_ZC_SAND10, VLC_CODEC_MMAL_ZC_RGB32 },
> +                                               FAKE_FMT() },
> +    { { VLC_CODEC_D3D9_OPAQUE,    VLC_CODEC_D3D11_OPAQUE },

That's a lot of entries for a single piece of hardware. We don't normally 
expose specific hardware pixel formats.

>                                                 FAKE_FMT() },
>      { { VLC_CODEC_D3D11_OPAQUE_10B, VLC_CODEC_D3D9_OPAQUE_10B,
>          VLC_CODEC_D3D11_OPAQUE_RGBA, VLC_CODEC_D3D11_OPAQUE_BGRA },


-- 
Rémi Denis-Courmont
http://www.remlab.net/