[vlc-devel] [PATCH] mmal: update the code from the one actually used in Raspbian

[Steve Lhomme]

On 2020-01-15 18:27, Rémi Denis-Courmont wrote:
> Le keskiviikkona 15. tammikuuta 2020, 17.46.31 EET Steve Lhomme a écrit :
>> diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
>> index 9b4ea14c31b..ef83ac3b4ad 100644
>> --- a/src/misc/fourcc.c
>> +++ b/src/misc/fourcc.c
>> @@ -816,8 +816,13 @@ static const struct
>>       { { VLC_CODEC_VDPAU_VIDEO_420, VLC_CODEC_VDPAU_VIDEO_422,
>>           VLC_CODEC_VDPAU_VIDEO_444, VLC_CODEC_VDPAU_OUTPUT },
>>                                                  FAKE_FMT() },
>> -    { { VLC_CODEC_ANDROID_OPAQUE, VLC_CODEC_MMAL_OPAQUE,
>> -        VLC_CODEC_D3D9_OPAQUE,    VLC_CODEC_D3D11_OPAQUE },
>> +    { { VLC_CODEC_ANDROID_OPAQUE },            FAKE_FMT() },
>> +    { { VLC_CODEC_MMAL_OPAQUE, VLC_CODEC_MMAL_ZC_SAND30   },
>> +                                               FAKE_FMT() },
>> +    { { VLC_CODEC_MMAL_ZC_I420,   VLC_CODEC_MMAL_ZC_SAND8,
>> +        VLC_CODEC_MMAL_ZC_SAND10, VLC_CODEC_MMAL_ZC_RGB32 },
>> +                                               FAKE_FMT() },
>> +    { { VLC_CODEC_D3D9_OPAQUE,    VLC_CODEC_D3D11_OPAQUE },
> 
> That's a lot of entries for a single piece of hardware. We don't normally
> expose specific hardware pixel formats.

The lines above and below say otherwise.

>>                                                  FAKE_FMT() },
>>       { { VLC_CODEC_D3D11_OPAQUE_10B, VLC_CODEC_D3D9_OPAQUE_10B,
>>           VLC_CODEC_D3D11_OPAQUE_RGBA, VLC_CODEC_D3D11_OPAQUE_BGRA },