[vlc-devel] [PATCH] mmal: update the code from the one actually used in Raspbian

[Jean-Baptiste Kempf]

Hi,

On Thu, 16 Jan 2020, at 09:52, Steve Lhomme wrote:
> If we decide to keep supporting MMAL (I'm OK to do it) then we should 
> (re)start from the code that people actually use in Raspbian, the 
> default RPI distribution. This code was also sponsored by Raspberry Pi.

We cannot not support rPI, seeing the amount of users doing video with it.

However, it would be nice if it was split in 3/5 patches.


> It's designed for 3.0. Porting decoder/vout code to 4.0 is not an easy 
> thing.

Especially since it is a moving target.

> 
> > won't immediately bit-rot, and the same problems won't occur again and again.
> 
> If we decide to support it I'd like to add a Raspbian target in the 
> buildbot so we don't forget to update/break it
> something else won't make it worse.
> 
> >> diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
> >> index 9b4ea14c31b..ef83ac3b4ad 100644
> >> --- a/src/misc/fourcc.c
> >> +++ b/src/misc/fourcc.c
> >> @@ -816,8 +816,13 @@ static const struct
> >>       { { VLC_CODEC_VDPAU_VIDEO_420, VLC_CODEC_VDPAU_VIDEO_422,
> >>           VLC_CODEC_VDPAU_VIDEO_444, VLC_CODEC_VDPAU_OUTPUT },
> >>                                                  FAKE_FMT() },
> >> -    { { VLC_CODEC_ANDROID_OPAQUE, VLC_CODEC_MMAL_OPAQUE,
> >> -        VLC_CODEC_D3D9_OPAQUE,    VLC_CODEC_D3D11_OPAQUE },
> >> +    { { VLC_CODEC_ANDROID_OPAQUE },            FAKE_FMT() },
> >> +    { { VLC_CODEC_MMAL_OPAQUE, VLC_CODEC_MMAL_ZC_SAND30   },
> >> +                                               FAKE_FMT() },
> >> +    { { VLC_CODEC_MMAL_ZC_I420,   VLC_CODEC_MMAL_ZC_SAND8,
> >> +        VLC_CODEC_MMAL_ZC_SAND10, VLC_CODEC_MMAL_ZC_RGB32 },
> >> +                                               FAKE_FMT() },
> >> +    { { VLC_CODEC_D3D9_OPAQUE,    VLC_CODEC_D3D11_OPAQUE },
> > 
> > That's a lot of entries for a single piece of hardware. We don't normally
> > expose specific hardware pixel formats.
> > 
> >>                                                  FAKE_FMT() },
> >>       { { VLC_CODEC_D3D11_OPAQUE_10B, VLC_CODEC_D3D9_OPAQUE_10B,
> >>           VLC_CODEC_D3D11_OPAQUE_RGBA, VLC_CODEC_D3D11_OPAQUE_BGRA },
> > 
> > 
> > -- 
> > Rémi Denis-Courmont
> > http://www.remlab.net/
> > 
> > 
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734