[vlc-devel] [PATCH] mmal: update the code from the one actually used in Raspbian

[Steve Lhomme]

On 2020-01-16 11:11, Rémi Denis-Courmont wrote:
> Those aren't GPU pixel formats.

They are
VDP_CHROMA_TYPE_420 + VDP_YCBCR_FORMAT_NV12
VDP_CHROMA_TYPE_422 + VDP_YCBCR_FORMAT_UYVY
VDP_CHROMA_TYPE_444 + VDP_YCBCR_FORMAT_NV12 (!)

> Le 16 janvier 2020 11:56:48 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
> 
>     On 2020-01-16 10:28, Rémi Denis-Courmont wrote:
> 
>         No they don't.
> 
> 
>     Yes they are.
> 
>         None of the existing opaque formats are that way, and
>         they should not.
> 
> 
>     Just a few examples of something you should know:
> 
>     VLC_CODEC_VDPAU_OUTPUT: Internal VDPAU RGBA 8 bits
>     VLC_CODEC_VDPAU_VIDEO_420: Internal VDPAU YUV 420 8 bits
>     VLC_CODEC_VDPAU_VIDEO_422: Internal VDPAU YUV 422 8 bits
>     VLC_CODEC_VDPAU_VIDEO_444: Internal VDPAU YUV 444 8 bits
> 
>     Anytime we add support for a hardware chroma we need the matching the
>     corresponding VLC chroma so we can convert to/from it and detect chroma
>     changes.
> 
>         -1.
> 
>         Le 16 janvier 2020 10:59:03 GMT+02:00, Steve Lhomme
>         <robux4 at ycbcr.xyz> a
>         écrit :
> 
>         On 2020-01-15 18:27, Rémi Denis-Courmont wrote:
> 
>         Le keskiviikkona 15. tammikuuta 2020, 17.46.31 EET Steve Lhomme
>         a écrit :
> 
>         diff --git a/src/misc/fourcc.c b/src/misc/fourcc.c
>         index 9b4ea14c31b..ef83ac3b4ad 100644
>         --- a/src/misc/fourcc.c
>         +++ b/src/misc/fourcc.c
>         @@ -816,8 +816,13 @@ static const struct
>         { { VLC_CODEC_VDPAU_VIDEO_420, VLC_CODEC_VDPAU_VIDEO_422,
>         VLC_CODEC_VDPAU_VIDEO_444, VLC_CODEC_VDPAU_OUTPUT },
>         FAKE_FMT() },
>         - { { VLC_CODEC_ANDROID_OPAQUE, VLC_CODEC_MMAL_OPAQUE,
>         - VLC_CODEC_D3D9_OPAQUE, VLC_CODEC_D3D11_OPAQUE },
>         + { { VLC_CODEC_ANDROID_OPAQUE }, FAKE_FMT() },
>         + { { VLC_CODEC_MMAL_OPAQUE, VLC_CODEC_MMAL_ZC_SAND30 },
>         + FAKE_FMT() },
>         + { { VLC_CODEC_MMAL_ZC_I420, VLC_CODEC_MMAL_ZC_SAND8,
>         + VLC_CODEC_MMAL_ZC_SAND10, VLC_CODEC_MMAL_ZC_RGB32 },
>         + FAKE_FMT() },
>         + { { VLC_CODEC_D3D9_OPAQUE, VLC_CODEC_D3D11_OPAQUE },
> 
>         That's a lot of entries for a single piece of hardware. We don't
>         normally
>         expose specific hardware pixel formats.
> 
> 
>         The lines above and below say otherwise.
> 
>         FAKE_FMT() },
>         { { VLC_CODEC_D3D11_OPAQUE_10B, VLC_CODEC_D3D9_OPAQUE_10B,
>         VLC_CODEC_D3D11_OPAQUE_RGBA, VLC_CODEC_D3D11_OPAQUE_BGRA },
>         ------------------------------------------------------------------------
>         vlc-devel mailing list
>         To unsubscribe or modify your subscription options:
>         https://mailman.videolan.org/listinfo/vlc-devel
> 
> 
>         -- 
>         Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>         excuser
>         ma brièveté.
>         ------------------------------------------------------------------------
>         vlc-devel mailing list
>         To unsubscribe or modify your subscription options:
>         https://mailman.videolan.org/listinfo/vlc-devel
> 
>     ------------------------------------------------------------------------
>     vlc-devel mailing list
>     To unsubscribe or modify your subscription options:
>     https://mailman.videolan.org/listinfo/vlc-devel
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>