[vlc-devel] [PATCH 2/2] vout: ios: remove useless glFlush

Alexandre Janniaux ajanni at videolabs.io
Thu Jan 16 17:57:24 CET 2020


glFlush send batched command from the CPU-side client to the GPU and
thus creates more commands, while glFinish wait for all CPU-side client
commands to be executed, including the one needing to be flushed.

Also, glFlush doesn't block on the command queue so it doesn't matter
for the issue fixed in 1399ebae2e123cf3ba112946014b59ef34d639dd.
---
 modules/video_output/ios.m | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/video_output/ios.m b/modules/video_output/ios.m
index 00d7dc5f29..695cde9f50 100644
--- a/modules/video_output/ios.m
+++ b/modules/video_output/ios.m
@@ -724,10 +724,7 @@ static void GLESSwap(vlc_gl_t *gl)
      * background.*/
     EAGLContext *previousEaglContext = [EAGLContext currentContext];
     if ([EAGLContext setCurrentContext:_eaglContext])
-    {
         glFinish();
-        glFlush();
-    }
     [EAGLContext setCurrentContext:previousEaglContext];
 }
 
-- 
2.25.0



More information about the vlc-devel mailing list