[vlc-devel] [PATCH] avcommon: refactor usage of `quiet' variable

[Alexandre Janniaux]

Hi,

On Mon, Jan 20, 2020 at 09:59:30AM +0200, Rémi Denis-Courmont wrote:
> Hi,
>
> I think there should be separate options for each affected module simply because there underlying logging systems use different classifications. We should not reduce this to a boolean.
>

I agree, but didn't introduce the log level in the current patch as it
wouldn't be use yet. Would you still prefer a loglevel now?

What I planned to achieve with this patch is fixing the libvlc 4.0
build for iOS, as this variable is required by avcodec but no shipped
module is providing it.

Regards,
--
Alexandre Janniaux
Videolabs

> Le 20 janvier 2020 09:14:49 GMT+02:00, Alexandre Janniaux <ajanni at videolabs.io> a écrit :
> >Hi,
> >
> >Any news on this ? Where should we move it?
> >
> >Regards,
> >--
> >Alexandre Janniaux
> >Videolabs
> >
> >On Thu, Dec 12, 2019 at 11:10:08AM +0100, Alexandre Janniaux wrote:
> >> Hi,
> >>
> >> On Thu, Dec 12, 2019 at 11:04:14AM +0100, Marvin Scholz wrote:
> >> > On 12 Dec 2019, at 10:01, Alexandre Janniaux wrote:
> >> >
> >> > > The `quiet' VLC variable is used although it is exposed only by
> >other
> >> > > non-mandatory modules. Rename it to avcodec/avformat-quiet so as
> >to
> >> > > prevent assertion on platform that won't ship with a module
> >exposing a
> >> > > quiet variable.
> >> >
> >> > Hi, thanks for the patch!
> >> >
> >> > While this approach works to fix the issue and seems certainly like
> >a
> >> > possible
> >> > solution to me, I think it would be more convenient to have just
> >one `quiet`
> >> > variable and not a per-module one. So maybe the variable should be
> >„owned“
> >> > by
> >> > the core instead?
> >> >
> >> > Although it seems we already have several module-specific quiet
> >options
> >> > so maybe we want to keep it that way even though to me it seems
> >weird…
> >>
> >> That's a good question, about moving it to libvlc-modules.c
> >> instead. I don't know, because it's quite alike the
> >> fullscreen option or volume option. I've never used this and
> >> don't really need it, but it was preventing vlc-ios 4.0 from
> >> running videos with avcodec/avformat.
> >>
> >> I'm fine with either what I did or moving it to
> >> libvlc-modules.c.
> >>
> >> Regards,
> >> --
> >> Alexandre Janniaux
> >> Videolabs
> >> _______________________________________________
> >> vlc-devel mailing list
> >> To unsubscribe or modify your subscription options:
> >> https://mailman.videolan.org/listinfo/vlc-devel
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel