[vlc-devel] [PATCH] core: increase file-caching

[Thomas Guillem]

On Thu, Jan 16, 2020, at 16:34, Steve Lhomme wrote:
> On 2020-01-16 15:40, Thomas Guillem wrote:
> > Forward-port of vlc-3.0.git: 576b4da8d674d8a98dd493e9b343f1875efde047
> > It's either this patch or my more complicated decoder latency branch. I think
> > this patch is safer.
> > 
> > Same value than the network one. In order to fix low-fps video with high cpu
> > count, as decided during the last technical meeting.
> > 
> > cf. background here:
> > https://mailman.videolan.org/pipermail/vlc-devel/2019-September/127432.html
> > ---
> >   src/libvlc-module.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> > index 1b85e8702b3..1e733662cf6 100644
> > --- a/src/libvlc-module.c
> > +++ b/src/libvlc-module.c
> > @@ -1965,7 +1965,7 @@ vlc_module_begin ()
> >   
> >       set_section( N_( "Advanced" ), NULL )
> >   
> > -    add_integer( "file-caching", MS_FROM_VLC_TICK(DEFAULT_PTS_DELAY),
> > +    add_integer( "file-caching", 1000,
> 
> You may convert the value from ticks or add a comment to what this value 
> corresponds (1 second).

It's done like network-caching, it could be improved, but I prefer to push this patch as it is for now.

> 
> >                    CACHING_TEXT, CACHING_LONGTEXT, true )
> >           change_integer_range( 0, 60000 )
> >           change_safe()
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> > 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel