[vlc-devel] [PATCH 0/6] qt: ensure the origin of mediatree callbacks

[Alexandre Janniaux]

Hi,

LGTM on the patchset, nit on missing first cap / ending dot
in commit message but not that important.

It indeed fixes the issues you're mentioning.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Jan 20, 2020 at 02:23:21PM +0100, Pierre Lamot wrote:
>   This patchset fixes issues where we receive callbacks from the media tree after
>   we change view. we now ensure that the callback comes from the node we're
>   monitoring in our model.
>
>   this patchset applies on top of Alexandre's patchset
>   "[PATCH 1/5] qt: networkmediamodel: use make_unique for unique_ptr"
>
>
> Pierre Lamot (6):
>   qt: reduce the number of calls on the UI thread on item removed in
>     NetworkMediaModel
>   qt: reduce the number of calls on the UI thread on removal in
>     NetworkDeviceModel
>   qt: forward the callback node to the SourceListener in remove
>     operations
>   qt: don't update the model when the callback comes from another node
>     in NetworkDeviceModel
>   qt: don't update the model when the callback comes from another node
>     in NetworkMediaModel
>   qt: use QUrl::FullyEncoded to convert QUrl to string in
>     NetworkMediaModel
>
>  modules/gui/qt/network/networkdevicemodel.cpp | 72 +++++++++++--------
>  modules/gui/qt/network/networkdevicemodel.hpp |  2 +-
>  modules/gui/qt/network/networkmediamodel.cpp  | 49 ++++++++-----
>  modules/gui/qt/network/networkmediamodel.hpp  |  2 +-
>  .../gui/qt/network/networksourcelistener.cpp  |  4 +-
>  .../gui/qt/network/networksourcelistener.hpp  |  2 +-
>  6 files changed, 80 insertions(+), 51 deletions(-)
>
> --
> 2.17.1
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel