[vlc-devel] [PATCH 01/24] opengl: move compat definition to gl_common.h

[Alexandre Janniaux]

Hi,
On Tue, Jan 28, 2020 at 04:39:47PM +0100, Romain Vimont wrote:
> On 1/28/20 4:32 PM, Alexandre Janniaux wrote:
> > Hi,
> >
> > I wonder if this change is really needed, those defines are
> > only used by the interop_sw.c right ?
>
> It is not really necessary, but I think that gl_common.h should define all
> compatibility-related stuff, regardless of whether it is used by one or more
> files.
>
> Btw, other values defined in gl_common.h are used by exactly one file
> (GL_RG16, GL_LUMINANCE16, GL_TEXTURE_LUMINANCE_SIZE, ...).

It's a good point, but it makes it makes specific needs non-local
which is harder to maintain, and I fear that it could lead to
creating another converter.h-like file, which is hard to edit
because many details for multiple compatibility issues are
interleaved without context.

Regards,
--
Alexandre Janniaux
Videolabs