[vlc-devel] [PATCH] core: object: clear res from vlc_object_delete()

[Thomas Guillem]

What I would like is being able to use objres in all modules without asking myself if the owner will handle it.

So what do we do ?
 - Should each modules owner handle the resource clearing themselves ? In that case, we need to expose objres API in VLC core (for submodules).
 - Or apply this patch (+modifications mentioned by Steve)



On Mon, Jan 27, 2020, at 19:53, Rémi Denis-Courmont wrote:
> Le maanantaina 27. tammikuuta 2020, 17.08.47 EET Thomas Guillem a écrit :
> > On Mon, Jan 27, 2020, at 15:00, Rémi Denis-Courmont wrote:
> > > Hi,
> > > 
> > > I don't think that we require an object to be deleted after a single
> > > module probe though (unlike the kernel), or do we?
> > No we don't require it, and nothing prevent to load/unload different kind of
> > module using one vlc_object.
> 
> In any case, you can't bind more than one module per object at a time if 
> modules use object resources. But if you can bind multiple modules 
> consecutively, then clearing resources at deletion is inadequate, as it could 
> lead to temporary linear resource leak.
> 
> IIRC, the kernel explicitly forbids binding a driver and an object more than 
> once, so then cleaning up resources at object deletion is a legitimate 
> simplification. But it does not seem like it for VLC - or at least not so far.
> 
> -- 
> Реми Дёни-Курмон
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel