[vlc-devel] [PATCH] configure: remove the CONFIGURE_LINE from the config.h

[Steve Lhomme]

On 2020-01-29 13:02, Rémi Denis-Courmont wrote:
> Config.log is not visible in binary packages.

And what's the use for that information from custom builds ?

> -1.
*-1

> Le 29 janvier 2020 11:27:12 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
> 
>     It's already in the config.log
> 
>     We don't need this information in the logs. In official builds we already know
>     the value. In custom builds we can always ask for it if we suspect there's a
>     wrong configuration. Plus it doesn't tell anything about the build environment
>     which impacts the (un)selected features of the code.
>     ------------------------------------------------------------------------
>       configure.ac        | 2 --
>       src/misc/messages.c | 1 -
>       2 files changed, 3 deletions(-)
> 
>     diff --git a/configure.ac b/configure.ac
>     index aeb2bb23e43..69b09dfe3ac 100644
>     --- a/configure.ac
>     +++ b/configure.ac
>     @@ -12,7 +12,6 @@ VERSION_DEV=dev
>       PKGDIR="vlc"
>       AC_SUBST([PKGDIR])
>       
>     -CONFIGURE_LINE="`echo "$0 $ac_configure_args" | sed -e 's/\\\/\\\\\\\/g'`"
>       CODENAME="Otto Chriek"
>       COPYRIGHT_YEARS="1996-2020"
>       
>     @@ -4486,7 +4485,6 @@ COPYRIGHT_MESSAGE="Copyright © ${COPYRIGHT_YEARS} the VideoLAN team"
>       AC_DEFINE_UNQUOTED([VERSION_MESSAGE], "${VERSION_MESSAGE}", [Simple version string])
>       AC_DEFINE_UNQUOTED([COPYRIGHT_MESSAGE], "${COPYRIGHT_MESSAGE}", [Copyright string])
>       AC_DEFINE_UNQUOTED([COPYRIGHT_YEARS], "${COPYRIGHT_YEARS}", [The copyright years])
>     -AC_DEFINE_UNQUOTED([CONFIGURE_LINE], "${CONFIGURE_LINE}", [The ./configure command line])
>       AC_DEFINE_UNQUOTED([PACKAGE_VERSION_MAJOR],${VERSION_MAJOR}, [version major number])
>       AC_DEFINE_UNQUOTED([PACKAGE_VERSION_MINOR],${VERSION_MINOR}, [version minor number])
>       AC_DEFINE_UNQUOTED([PACKAGE_VERSION_REVISION],${VERSION_REVISION}, [version revision number])
>     diff --git a/src/misc/messages.c b/src/misc/messages.c
>     index 08725113897..2e180a0f992 100644
>     --- a/src/misc/messages.c
>     +++ b/src/misc/messages.c
>     @@ -48,7 +48,6 @@ static void vlc_LogSpam(vlc_object_t *obj)
>           msg_Dbg(obj, "VLC media player - %s", VERSION_MESSAGE);
>           msg_Dbg(obj, "%s", COPYRIGHT_MESSAGE);
>           msg_Dbg(obj, "revision %s", psz_vlc_changeset);
>     -    msg_Dbg(obj, "configured with %s", CONFIGURE_LINE);
>       }
>       
>       struct vlc_logger {
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>