[vlc-devel] [PATCH] contrib: lua: remove the cross compiler environment when compiling native luac

[Alexandre Janniaux]

Hi,

Can you provide more context about why and where this is
needed in the commit message?

Otherwise, it seems that CPPFLAGS is already defined right
above for WIN32 in cross compile, and HAVE_CROSS_COMPILE
used there, maybe HAVE_WIN32 / HAVE_CROSS_COMPILE can be
swapped and this code moved there?

Regards,
--
Alexandre Janniuax
Videolabs

On Wed, Jan 29, 2020 at 12:22:16PM +0100, Steve Lhomme wrote:
> ---
>  contrib/src/lua/rules.mak | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/contrib/src/lua/rules.mak b/contrib/src/lua/rules.mak
> index 309b9940fe5..ca6c207ba32 100644
> --- a/contrib/src/lua/rules.mak
> +++ b/contrib/src/lua/rules.mak
> @@ -94,6 +94,11 @@ LUACVARS=CPPFLAGS="-DLUA_DL_DLL"
>  endif
>  endif
>
> +ifdef HAVE_CROSS_COMPILE
> +# Cancel the special environment for the host
> +LUACVARS+=CFLAGS="" CPPFLAGS="" LDFLAGS=""
> +endif
> +
>  luac: lua-$(LUA_VERSION).tar.gz .sum-luac
>  	# DO NOT use the same intermediate directory as the lua target
>  	rm -Rf -- $@-$(LUA_VERSION) $@
> --
> 2.17.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel