[vlc-devel] [PATCH] contrib: lua: remove the cross compiler environment when compiling native luac

[Rémi Denis-Courmont]

Le keskiviikkona 29. tammikuuta 2020, 18.32.17 EET Alexandre Janniaux a écrit 
:
> Hi,
> 
> On Wed, Jan 29, 2020 at 06:22:49PM +0200, Rémi Denis-Courmont wrote:
> > This makes no sense. If HAVE_CROSS_COMPILE is set, the compilation is NOT
> > native, by definition, and the flags are necessary.
> 
> It's about luac, which is called by the build machine and
> checked in configure.ac. I don't think that it's relevant
> to say that the compilation is not native then.

Okay well the description could do a better job at explaining, and this  And 
the variables could have a more logical name because that's not a Luac-specific 
issue really.

> This is the only tool we have which is not in extras/tools
> right ?

Contribs build any and all the tools needed on decent Linux distro or other 
OSS operating system. It might be that only luac is needed so far, but I don't 
think that's something that should be assumed.

I am not touching extras/tools with a ten foot pole. It's the same crappy 
broken old logic and structure as the old contribs. Eight and a half years on.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/