[vlc-devel] [PATCH] contrib: fix the PKG_CONFIG_LIBDIR path

[Alexandre Janniaux]

Hi,

Mine is in /usr/$(HOST)/lib/pkgconfig/. I don't think it
should be fixed by modifying them but instead by using a
dedicated wrapper script overriding this variable, like
suggested by autotools.io[1].

In particular, the path will also be wrong when using an
external (non-distro provided and not installed in /usr)
libdir.

We only have to choose one version and maybe provide the
symlinks in the target build recipee, or generate the
correct script and define PKG_CONFIG.

[1] https://autotools.io/pkgconfig/cross-compiling.html

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Jan 30, 2020 at 04:11:52PM +0100, Steve Lhomme wrote:
> Not sure if it's distro dependant but the Raspbian packages are found in
> /usr/lib/arm-linux-gnueabihf/pkgconfig
> ---
>  contrib/src/main.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> index 1b7ff3190f3..8892c75206f 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -226,7 +226,7 @@ ifdef HAVE_CROSS_COMPILE
>  # This inhibits .pc file from within the cross-compilation toolchain sysroot.
>  # Hopefully, nobody ever needs that.
>  PKG_CONFIG_PATH := /usr/share/pkgconfig
> -PKG_CONFIG_LIBDIR := /usr/$(HOST)/lib/pkgconfig
> +PKG_CONFIG_LIBDIR := /usr/lib/$(HOST)/pkgconfig
>  export PKG_CONFIG_LIBDIR
>  endif
>  PKG_CONFIG_PATH := $(PREFIX)/lib/pkgconfig:$(PKG_CONFIG_PATH)
> --
> 2.17.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel