[vlc-devel] [PATCH] contrib: allow using prebuilt packages when cross-compiling

[Alexandre Janniaux]

Hi,

While I want such patch as much as you want, this doesn't
respect the original intent of this, which is avoiding using
system libraries for targets when we don't want to, so it
should probably be enabled with an option somehow imho.

An example of such issue would be linking some system
library while building for android, because you have an
environment alike available system-wide for other purpose,
and not shipping the shared object that was linked.

Regards,
--
Alexandre Janniaux
Videolabs

On Thu, Jan 30, 2020 at 04:13:02PM +0100, Steve Lhomme wrote:
> In the case of Raspbian there's a heavily patched libavcodec which we can
> access through pre-built packages.
> Qt cross compiling also a major PITA which we can avoid this way.
> ---
>  contrib/src/main.mak | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
> index 27722baf513..1b7ff3190f3 100644
> --- a/contrib/src/main.mak
> +++ b/contrib/src/main.mak
> @@ -45,13 +45,10 @@ ifeq ($(ARCH)-$(HAVE_WIN32),aarch64-1)
>  HAVE_WIN64 := 1
>  endif
>
> +need_pkg = $(shell $(PKG_CONFIG) $(1) || echo 1)
>  ifdef HAVE_CROSS_COMPILE
> -need_pkg = 1
> -else
>  ifeq ($(findstring mingw32,$(BUILD)),mingw32)
>  need_pkg = $(shell PKG_CONFIG_LIBDIR="${PKG_CONFIG_PATH}" $(PKG_CONFIG) $(1) || echo 1)
> -else
> -need_pkg = $(shell $(PKG_CONFIG) $(1) || echo 1)
>  endif
>  endif
>
> --
> 2.17.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel