[vlc-devel] [PATCH v2 22/22] opengl: add mock filter

[Alexandre Janniaux]

Hi,

On Wed, Jul 01, 2020 at 02:04:21PM +0200, Thomas Guillem wrote:
>
> On Wed, Jul 1, 2020, at 13:03, Francois Cartegnie wrote:
> > Le 01/07/2020 à 12:30, Romain Vimont a écrit :
> > > This mock filter simplifies testing of the OpenGL filter engine.
> >
> > Should be in conditionally built with tests target then.
>
> No, we decided to use noinst for mock modules. cf. efb54cb748b4b837c383cce2d29d78dd71891eb9
> Quoting Rémi:
>     "Test plugins should use noinst_*, IMO. With check_*, you would end up with
>     stale plugins and potentially weird crashes due to ABI breaks if alternating
>     make all and make check."

In addition, it is pretty useful to use them in dev
environments on cross-platforms like Android and iOS,
for which `make check` makes little sense.

Regards,
--
Alexandre Janniaux
Videolabs

>
> >
> > > +vlc_module_begin()
> > > +    set_shortname("mock")
> > > +    set_description("mock OpenGL filter")
> > > +    set_category(CAT_VIDEO)
> > > +    set_subcategory(SUBCAT_VIDEO_VFILTER)
> > > +    set_capability("opengl filter", 0)
> > > +    set_callback(Open)
> > > +    add_float(MOCK_CFG_PREFIX "angle", 0.f, NULL, NULL, false)
> > > +    add_float(MOCK_CFG_PREFIX "speed", 0.f, NULL, NULL, false) /* in rotation per minute */
> > > +    add_bool(MOCK_CFG_PREFIX "mask", false, NULL, NULL, false)
> > > +vlc_module_end()
> > >
> >
> >
> > --
> > Francois Cartegnie
> > VideoLAN - VLC Developer
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel