[vlc-devel] [PATCH v2 22/22] opengl: add mock filter

Rémi Denis-Courmont remi at remlab.net
Wed Jul 1 15:32:19 CEST 2020

Le keskiviikkona 1. heinäkuuta 2020, 16.11.40 EEST Francois Cartegnie a écrit 
> Le 01/07/2020 à 14:31, Alexandre Janniaux a écrit :
> >> No, we decided to use noinst for mock modules. cf.
> >> efb54cb748b4b837c383cce2d29d78dd71891eb9>> 
> >> Quoting Rémi:
> >>     "Test plugins should use noinst_*, IMO. With check_*, you would end
> >>     up with
> >>     stale plugins and potentially weird crashes due to ABI breaks if
> >>     alternating make all and make check."
> > 
> > In addition, it is pretty useful to use them in dev
> > environments on cross-platforms like Android and iOS,
> > for which `make check` makes little sense.
> Seems that changes with wind direction
> 8ff4b51484d41f125e034b0fea69889dc77acf98

Err, no? At least I don't recall ever recommending using configure flags to 
enable test targets.

If it's really only useful in automated tests, there are pros and cons to 
noinst vs check. If it's also useful in debugging or manual testing, then 
noinst seems both more proper and more convenient in any case.


More information about the vlc-devel mailing list