[vlc-devel] [PATCH] picture: always copy context when cloning

Alexandre Janniaux ajanni at videolabs.io
Wed Jul 1 17:03:06 CEST 2020


Hi,

Thank you for the historical context, I'll add it to the
patch for the future patchset.

Regards,
--
Alexandre Janniaux
Videolabs

On Wed, Jul 01, 2020 at 04:36:31PM +0300, Rémi Denis-Courmont wrote:
> Le tiistaina 30. kesäkuuta 2020, 20.50.28 EEST Alexandre Janniaux a écrit :
> > picture_Clone was copying the original picture context into the new
> > clone while picture_pool_Clone wasn't.
>
> That is, or at least was, intended. In the old pull model, the context was
> attached after taking the picture from the pool, and detached when returning
> it.
>
> Admittedly with the push model, it's ripe for rationalisation and clean-up,
> but Steve might have a point that it's better to wait for actual use.
>
> --
> 雷米‧德尼-库尔蒙
> http://www.remlab.net/
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list