[vlc-devel] [PATCH] Track counting always selects "video" type track list despite category choice (audio/spu) -> assert failure in vlc_player_GetTrackAt() from ./src/player/player.c

[Thomas Guillem]

Hello,

Thanks for the patch.

Nitpicking, the commit title could be improved, cf. https://chris.beams.io/posts/git-commit/
The title should be short, and the message should contain the explanation (if the title is not self-explanatory).

I would have written:

"lib: fix libvlc_media_player_get_track_from_id() always using the VIDEO count"

Best regards,
Thomas Guillem

On Thu, Jul 2, 2020, at 19:09, Romain Vimont wrote:
> LGTM
> 
> Thank you
> 
> (ref: #24921)
> 
> On Thu, Jul 02, 2020 at 06:32:55PM +0200, Pascal Souchet wrote:
> > ---
> >  lib/media_player.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/media_player.c b/lib/media_player.c
> > index 2f390468c4..9c7a7a76aa 100644
> > --- a/lib/media_player.c
> > +++ b/lib/media_player.c
> > @@ -1871,7 +1871,7 @@ x( libvlc_media_player_t *p_mi,
> >      for (size_t i = 0; i < ARRAY_SIZE(cats); ++i)
> >      {
> >          enum es_format_category_e cat = cats[i];
> > -        size_t count = vlc_player_GetTrackCount(player, VIDEO_ES);
> > +        size_t count = vlc_player_GetTrackCount(player, cat);
> >  
> >          for (size_t j = 0; j < count; ++j)
> >          {
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel