[vlc-devel] [PATCH] lib: fix track count in get_track_from_id()

[P S]

Hello,

Thank you all for helping me to write properly.
This is my very first post here and i'm not very familiar with git
send-email command.
I did not know how to separate the subject from the explanation, I will do
better next time.
Please accept my apology for not following the rules.

Best regards,

Pascal Souchet
ps: English is not my native language, you had guessed it :-)

Le jeu. 2 juil. 2020 à 22:44, Romain Vimont <rom1v at videolabs.io> a écrit :

> On Thu, Jul 02, 2020 at 09:12:32PM +0200, Thomas Guillem wrote:
> > Hello,
> >
> > Thanks for the patch.
> >
> > Nitpicking, the commit title could be improved, cf.
> https://chris.beams.io/posts/git-commit/
> > The title should be short, and the message should contain the
> explanation (if the title is not self-explanatory).
> >
> > I would have written:
> >
> > "lib: fix libvlc_media_player_get_track_from_id() always using the VIDEO
> count"
>
> Or even "lib: fix track count in get_track_from_id()" to respect the
> 50/72 rule :)
>
> Regards
>
> >
> > Best regards,
> > Thomas Guillem
> >
> > On Thu, Jul 2, 2020, at 19:09, Romain Vimont wrote:
> > > LGTM
> > >
> > > Thank you
> > >
> > > (ref: #24921)
> > >
> > > On Thu, Jul 02, 2020 at 06:32:55PM +0200, Pascal Souchet wrote:
> > > > ---
> > > >  lib/media_player.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/lib/media_player.c b/lib/media_player.c
> > > > index 2f390468c4..9c7a7a76aa 100644
> > > > --- a/lib/media_player.c
> > > > +++ b/lib/media_player.c
> > > > @@ -1871,7 +1871,7 @@ x( libvlc_media_player_t *p_mi,
> > > >      for (size_t i = 0; i < ARRAY_SIZE(cats); ++i)
> > > >      {
> > > >          enum es_format_category_e cat = cats[i];
> > > > -        size_t count = vlc_player_GetTrackCount(player, VIDEO_ES);
> > > > +        size_t count = vlc_player_GetTrackCount(player, cat);
> > > >
> > > >          for (size_t j = 0; j < count; ++j)
> > > >          {
> > > > --
> > > > 2.17.1
> > > >
> > > > _______________________________________________
> > > > vlc-devel mailing list
> > > > To unsubscribe or modify your subscription options:
> > > > https://mailman.videolan.org/listinfo/vlc-devel
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200702/b605b370/attachment.html>