[vlc-devel] [PATCH 13/14] videotoolbox: clarify log messages

Marvin Scholz epirat07 at gmail.com
Fri Jul 3 04:27:43 CEST 2020


Actually mention what is printed so that it's easier to know
where to look for the meaning of these constants
---
 modules/codec/videotoolbox.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/modules/codec/videotoolbox.c b/modules/codec/videotoolbox.c
index 96ea0bdbd4..88b3d08472 100644
--- a/modules/codec/videotoolbox.c
+++ b/modules/codec/videotoolbox.c
@@ -1201,7 +1201,8 @@ static int StartVideoToolbox(decoder_t *p_dec)
     if (p_sys->i_cvpx_format != 0)
     {
         OSType chroma = htonl(p_sys->i_cvpx_format);
-        msg_Warn(p_dec, "forcing CVPX format: %4.4s", (const char *) &chroma);
+        msg_Warn(p_dec, "forcing output chroma (kCVPixelFormatType): %4.4s",
+            (const char *) &chroma);
         cfdict_set_int32(destinationPixelBufferAttributes,
                          kCVPixelBufferPixelFormatTypeKey,
                          p_sys->i_cvpx_format);
@@ -2014,7 +2015,7 @@ static int UpdateVideoFormat(decoder_t *p_dec, CVPixelBufferRef imageBuffer)
     }
 
     OSType cvfmt = CVPixelBufferGetPixelFormatType(imageBuffer);
-    msg_Info(p_dec, "vt cvpx chroma: %4.4s",
+    msg_Info(p_dec, "output chroma (kCVPixelFormatType): %4.4s",
              (const char *)&(OSType) { htonl(cvfmt) });
     switch (cvfmt)
     {
-- 
2.24.3 (Apple Git-128)



More information about the vlc-devel mailing list