[vlc-devel] [PATCH 1/2] vout: don't assume there's a parent lock for SpuRenderText

[Steve Lhomme]

LGTM for both

On 2020-07-02 22:00, Francois Cartegnie wrote:
> spu_Attach could occur before lock
> ---
>   src/video_output/vout_subpictures.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/video_output/vout_subpictures.c b/src/video_output/vout_subpictures.c
> index b7c6f6ea4a..3248c86bfc 100644
> --- a/src/video_output/vout_subpictures.c
> +++ b/src/video_output/vout_subpictures.c
> @@ -313,10 +313,10 @@ static void SpuRenderText(spu_t *spu,
>                             const vlc_fourcc_t *chroma_list)
>   {
>       spu_private_t *sys = spu->p;
> -    filter_t *text = sys->text;
>       assert(region->fmt.i_chroma == VLC_CODEC_TEXT);
>   
>       vlc_mutex_lock(&sys->textlock);
> +    filter_t *text = sys->text;
>       if(text)
>       {
>           // assume rendered text is in sRGB if nothing is set
> -- 
> 2.25.4
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>