[vlc-devel] [PATCH] contrib: matroska: remove the -O2 forcing

Alexandre Janniaux ajanni at videolabs.io
Mon Jul 6 12:11:04 CEST 2020


Hi,

LGTM, not needed since c764461180d70d1c9fa81e72cd7ad9d9b289eea6.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Jul 06, 2020 at 11:40:22AM +0200, Steve Lhomme wrote:
> It seems to work without now.
> ---
>  contrib/src/matroska/rules.mak | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/contrib/src/matroska/rules.mak b/contrib/src/matroska/rules.mak
> index fca7e49e0c5..c455d2f912d 100644
> --- a/contrib/src/matroska/rules.mak
> +++ b/contrib/src/matroska/rules.mak
> @@ -21,10 +21,7 @@ matroska: libmatroska-$(MATROSKA_VERSION).tar.xz .sum-matroska
>  	$(call pkg_static,"libmatroska.pc.in")
>  	$(MOVE)
>
> -# O2 optimization due to iOS issue https://code.videolan.org/videolan/vlc-ios/issues/248
> -MATROSKA_CXXFLAGS := $(CXXFLAGS) $(PIC) -O2
> -
>  .matroska: matroska toolchain.cmake
> -	cd $< && $(HOSTVARS_PIC) CXXFLAGS="$(MATROSKA_CXXFLAGS)" $(CMAKE)
> +	cd $< && $(HOSTVARS_PIC) $(CMAKE)
>  	cd $< && $(MAKE) install
>  	touch $@
> --
> 2.26.2
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list