[vlc-devel] [PATCH 09/10] contrib: do the fetch before building everything

Alexandre Janniaux ajanni at videolabs.io
Mon Jul 6 18:59:38 CEST 2020


Hi,

I agree, if you want to fetch before building you should
probably execute `make fetch` before `make` instead.

Regards,
--
Alexandre Janniaux
Videolabs

On Mon, Jul 06, 2020 at 07:26:41PM +0300, Rémi Denis-Courmont wrote:
> Le lundi 6 juillet 2020, 17:45:19 EEST Steve Lhomme a écrit :
> > On 2020-07-06 16:26, Rémi Denis-Courmont wrote:
> > > Le lundi 6 juillet 2020, 16:14:11 EEST Steve Lhomme a écrit :
> > >> This avoids starting building and stopping in the middle if some tarballs
> > >> can't be downloaded.
> > >
> > > Nack. This breaks downloading and bilding in parallel.
> >
> > Can you explain why it would break it ? It works fine here and in the CI.
>
> Yeah so this pach actually makes no sense whatsoever. It adds a completely
> bogus dependency to install that is already an indirect dependency anyway.
>
> Still nack.
>
> --
> Rémi Denis-Courmont
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list