[vlc-devel] [PATCH 09/10] contrib: do the fetch before building everything

[Steve Lhomme]

On 2020-07-06 18:26, Rémi Denis-Courmont wrote:
> Le lundi 6 juillet 2020, 17:45:19 EEST Steve Lhomme a écrit :
>> On 2020-07-06 16:26, Rémi Denis-Courmont wrote:
>>> Le lundi 6 juillet 2020, 16:14:11 EEST Steve Lhomme a écrit :
>>>> This avoids starting building and stopping in the middle if some tarballs
>>>> can't be downloaded.
>>>
>>> Nack. This breaks downloading and bilding in parallel.
>>
>> Can you explain why it would break it ? It works fine here and in the CI.
> 
> Yeah so this pach actually makes no sense whatsoever. It adds a completely
> bogus dependency to install that is already an indirect dependency anyway.
> 
> Still nack.

You still do not explain how bogus it is. If the dependency already 
exists how come it will break things ? The only difference is the order 
in which things are extracted and built. Dependencies between packages 
and their sources are still kept.

Maybe there's a valid reason, but I don't see it.