[vlc-devel] [PATCH 09/10] contrib: do the fetch before building everything

[Alexandre Janniaux]

Hi,

If you force this within the Makefile, it means that every
builds are not able to pipeline fetch and build, so it will
be slower for everybody, while there's most of the time no
point in sequencing fetching and building since contribs
builds are supposed to work if merged in the tree.

In short, this patch is making contribs builds slower for
everybody while it only concerns CI or developers.

Since you can have the same effect by calling the following
commands, this patch might not be even needed.

	make fetch
	make

Regards,
--
Alexandre Janniaux
Videolabs

On Tue, Jul 07, 2020 at 07:10:45AM +0200, Steve Lhomme wrote:
> On 2020-07-06 18:59, Alexandre Janniaux wrote:
> > Hi,
> >
> > I agree, if you want to fetch before building you should
> > probably execute `make fetch` before `make` instead.
>
> Why should I ?
>
> > Regards,
> > --
> > Alexandre Janniaux
> > Videolabs
> >
> > On Mon, Jul 06, 2020 at 07:26:41PM +0300, Rémi Denis-Courmont wrote:
> > > Le lundi 6 juillet 2020, 17:45:19 EEST Steve Lhomme a écrit :
> > > > On 2020-07-06 16:26, Rémi Denis-Courmont wrote:
> > > > > Le lundi 6 juillet 2020, 16:14:11 EEST Steve Lhomme a écrit :
> > > > > > This avoids starting building and stopping in the middle if some tarballs
> > > > > > can't be downloaded.
> > > > >
> > > > > Nack. This breaks downloading and bilding in parallel.
> > > >
> > > > Can you explain why it would break it ? It works fine here and in the CI.
> > >
> > > Yeah so this pach actually makes no sense whatsoever. It adds a completely
> > > bogus dependency to install that is already an indirect dependency anyway.
> > >
> > > Still nack.
> > >
> > > --
> > > Rémi Denis-Courmont
> > >
> > >
> > > _______________________________________________
> > > vlc-devel mailing list
> > > To unsubscribe or modify your subscription options:
> > > https://mailman.videolan.org/listinfo/vlc-devel
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel