[vlc-devel] [PATCH v2 09/13] contrib: add an extract phase to extract all the sources that will be built

Rémi Denis-Courmont remi at remlab.net
Tue Jul 7 19:10:29 CEST 2020


If you don't build them, there's no way to match them with the build content.

This is not only useless but it'll cause confusion by generating incorrect traces.

Besides there *cannot* be distinction between extraction and build. Some packages literally don't have separate steps. And even those that do, can and typically do have generated sources.

-1.

Le 7 juillet 2020 08:29:30 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>This is convenient for Windows builds with PDB. It allows extracting
>all
>the sources to see the debugged sources without having to build them.
>---
> contrib/src/help.txt | 1 +
> contrib/src/main.mak | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/contrib/src/help.txt b/contrib/src/help.txt
>index d64ca8ef2c8..d2bd17ee5ea 100644
>--- a/contrib/src/help.txt
>+++ b/contrib/src/help.txt
>@@ -4,6 +4,7 @@ Other targets:
>  * make install      same as "make"
>  * make prebuilt     fetch and install prebuilt binaries
>  * make list         list packages
>+ * make extract      extract required source tarballs
>  * make fetch        fetch required source tarballs
>  * make fetch-all    fetch all source tarballs
>  * make distclean    clean everything and undo bootstrap
>diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>index 1df4e52bd2f..6cf9037c92d 100644
>--- a/contrib/src/main.mak
>+++ b/contrib/src/main.mak
>@@ -480,6 +480,7 @@ PKGS := $(sort $(PKGS_MANUAL) $(PKGS_DEPS))
> 
> fetch: $(PKGS:%=.sum-%)
> fetch-all: $(PKGS_ALL:%=.sum-%)
>+extract: $(PKGS)
> install: $(PKGS:%=.%)
> 
> mostlyclean:
>@@ -546,7 +547,7 @@ list:
> help:
> 	@cat $(SRC)/help.txt
> 
>-.PHONY: all fetch fetch-all install mostlyclean clean distclean
>package list help prebuilt
>+.PHONY: all fetch fetch-all extract install mostlyclean clean
>distclean package list help prebuilt
> 
> CMAKE_SYSTEM_NAME =
> ifdef HAVE_WIN32
>-- 
>2.26.2
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20200707/6379084b/attachment.html>


More information about the vlc-devel mailing list