[vlc-devel] [PATCH v4 16/20] opengl: pass picture date to filters

Romain Vimont rom1v at videolabs.io
Wed Jul 8 12:30:55 CEST 2020

On Wed, Jul 08, 2020 at 01:16:09PM +0300, Rémi Denis-Courmont wrote:
> Le mardi 7 juillet 2020, 13:33:59 EEST Romain Vimont a écrit :
> > Expose the date of the input picture_t to the OpenGL filter.
> > 
> > As the date is directly coming from the input picture without
> > modification, its value and semantic is defined by the previous layer
> > forwarding the picture to the OpenGL filters.
> In other words, you cannot really make any assumption on the date and thus 
> cannot really use it in any meaningful manner. That does not look like it 
> should be exposed as it will only lead to incorrect assumptions in filter and 
> later compatibility breaks.

In a video filter (filter_t), pf_video_filter() gives the picture_t,
which provides the date. This date is used by several filters (e.g. fps
and deinterlace filters).

The goal is to run OpenGL filters from a video filter, so in
pf_video_filter(), the picture_t is passed to the OpenGL filter.

It would be meaningless to expose the whole picture_t to the OpenGL
filter itself (it must use the GLSL function vlc_texture() to access the
input texture), but it is still important to forward some of its
properties (like the date), to be able to implement filters
like fps or deinterlace in OpenGL.

> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

More information about the vlc-devel mailing list