[vlc-devel] [PATCH v2 12/13] contrib: vorbisenc: add a vorbisenc rule

[Steve Lhomme]

On 2020-07-07 19:13, Rémi Denis-Courmont wrote:
> No, there is no hard rule that there should be an extraction step, never 
> was. this package being a case in point.

There's no rule that says it shouldn't. There's already a dummy touch 
for the same target, case in point.

> -1

+1

> Le 7 juillet 2020 08:29:33 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> a 
> écrit :
> 
>     Packages should have a .sum-<PKG> .<PKG> and <PKG> rule.
>     ------------------------------------------------------------------------
>       contrib/src/vorbis/rules.mak | 6 +++++-
>       1 file changed, 5 insertions(+), 1 deletion(-)
> 
>     diff --git a/contrib/src/vorbis/rules.mak b/contrib/src/vorbis/rules.mak
>     index 0990125f1d1..8e60f672b52 100644
>     --- a/contrib/src/vorbis/rules.mak
>     +++ b/contrib/src/vorbis/rules.mak
>     @@ -43,7 +43,11 @@ DEPS_vorbis = ogg $(DEPS_ogg)
>       .sum-vorbisenc: .sum-vorbis
>       	touch $@
>       
>     +# A missing vorbisenc will trigger a vorbis build that contains vorbisenc
>       DEPS_vorbisenc = vorbis $(DEPS_vorbis)
>       
>     -.vorbisenc:
>     +vorbisenc: .vorbisenc
>     +	touch $@
>     +
>     +.vorbisenc: .sum-vorbisenc
>       	touch $@
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>